Maintain DAC field offsets in EECodeGenManager #117721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a DAC (Data Access Component) build issue where field offsets in EECodeGenManager became misaligned, causing initialization problems and random crashes during debugging. The fix ensures that the m_delayUnload field is available in both runtime and DAC builds to maintain proper field alignment.
- Removes conditional compilation (
#ifndef DACCESS_COMPILE) around them_delayUnloadfield - Ensures consistent field layout between runtime and DAC builds
- Prevents uninitialized
m_storeRichDebugInfofield that was causing crashes
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
steveisok
approved these changes
Jul 16, 2025
AaronRobinsonMSFT
approved these changes
Jul 16, 2025
|
/ba-g failures are unrelated |
This was referenced Jul 16, 2025
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #116354 added a field to EECodeGenManager which was enabled in the runtime but #ifdef'd out in the DAC. This caused the
m_storeRichDebugInfofield to become uninitialized in the DAC build, resulting in random crashes while debugging.