Obsolete XsltSettings.EnableScript with SYSLIB0062 #117701
Merged
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jeffhandley <[email protected]>
Copilot
AI
changed the title
[WIP] [API Proposal]: Obsolete XsltSettings.EnableScript
Obsolete XsltSettings.EnableScript with SYSLIB0062
Jul 16, 2025
Copilot finished work on behalf of
jeffhandley
July 16, 2025 08:08
jeffhandley
reviewed
Jul 16, 2025
src/libraries/System.Xml.ReaderWriter/ref/System.Xml.ReaderWriter.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jeffhandley <[email protected]>
Copilot finished work on behalf of
jeffhandley
July 16, 2025 16:45
This was referenced Jul 16, 2025
Open
jeffhandley
approved these changes
Jul 17, 2025
|
Failures are known and unrelated |
ericstj
added
the
breaking-change
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
This comment was marked as resolved.
This comment was marked as resolved.
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/QilGeneratorEnv.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/XslAstAnalyzer.cs
Show resolved
Hide resolved
tannergooding
approved these changes
Jul 17, 2025
Co-authored-by: tannergooding <[email protected]>
jeffhandley
reviewed
Jul 17, 2025
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/XslAstAnalyzer.cs
Outdated
Show resolved
Hide resolved
…ocks Co-authored-by: jeffhandley <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
…bsolete API usage blocks Co-authored-by: jeffhandley <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Copilot finished work on behalf of
jeffhandley
July 17, 2025 20:06
jeffhandley
reviewed
Jul 20, 2025
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/Compiler.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 21, 2025
3 tasks
|
[Breaking change]: System.Xml.Xsl.XsltSettings.EnableScript Property marked as Obsolete (dotnet/docs#47504) created to document the breaking change. Skipping the email notification to the breaking changes distribution list since the property didn't have any functioning behavior previously. |
jeffhandley
removed
the
needs-breaking-change-doc-created
|
/ba-g Failures are timeouts in unrelated tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR obsoletes the
XsltSettings.EnableScriptproperty with diagnostic IDSYSLIB0062to help users migrating from .NET Framework to modern .NET.Background
XSLT Script blocks are supported only in .NET Framework and are not supported on .NET Core or .NET 5+. The
EnableScriptproperty has no legitimate value on modern .NET:false: simply skips script blocks (expected behavior anyway)true: throwsPlatformNotSupportedException(script compilation not supported)Obsoleting this API turns a runtime error into a build warning, providing better guidance for migration.
Changes Made
src/libraries/Common/src/System/Obsoletions.cs[Obsolete]attribute toEnableScriptproperty in both source and reference assembliesSYSLIB0062SYSLIB0062toNoWarnlist for facade assembliesExample
The warning message:
XSLT Script blocks are not supported on .NET Core or .NET 5 or later.Testing
Fixes #108287.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.