Skip to content

Implement various SVE2 Multiply Instructions #117660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

Implement various SVE2 Multiply Instructions #117660

merged 3 commits into from
Jul 16, 2025
+1,606 −263

Conversation

snickolls-arm
Copy link
Contributor

Includes:

  • MultiplyAddBySelectedScalar
  • MultiplyBySelectedScalar
  • MultiplyBySelectedScalarWideningEven
  • MultiplyBySelectedScalarWideningEvenAndAdd
  • MultiplyBySelectedScalarWideningEvenAndSubtract
  • MultiplyBySelectedScalarWideningOdd
  • MultiplyBySelectedScalarWideningOddAndAdd
  • MultiplyBySelectedScalarWideningOddAndSubtract
  • MultiplySubtractBySelectedScalar
  • MultiplyWideningEven
  • MultiplyWideningEvenAndAdd
  • MultiplyWideningEvenAndSubtract
  • MultiplyWideningOdd
  • MultiplyWideningOddAndAdd
  • MultiplyWideningOddAndSubtract
  • PolynomialMultiply
  • PolynomialMultiplyWideningEven
  • PolynomialMultiplyWideningOdd

@snickolls-arm
Implement various SVE2 Multiply Instructions
d0d7c44 
Includes:
* MultiplyAddBySelectedScalar
* MultiplyBySelectedScalar
* MultiplyBySelectedScalarWideningEven
* MultiplyBySelectedScalarWideningEvenAndAdd
* MultiplyBySelectedScalarWideningEvenAndSubtract
* MultiplyBySelectedScalarWideningOdd
* MultiplyBySelectedScalarWideningOddAndAdd
* MultiplyBySelectedScalarWideningOddAndSubtract
* MultiplySubtractBySelectedScalar
* MultiplyWideningEven
* MultiplyWideningEvenAndAdd
* MultiplyWideningEvenAndSubtract
* MultiplyWideningOdd
* MultiplyWideningOddAndAdd
* MultiplyWideningOddAndSubtract
* PolynomialMultiply
* PolynomialMultiplyWideningEven
* PolynomialMultiplyWideningOdd
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 15, 2025
@snickolls-arm
Copy link
Contributor Author

@amanasifkhalid @a74nh #115479

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

amanasifkhalid
amanasifkhalid suggested changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing some APIs in the .cs files, for example MultiplyWideningEvenAndSubtract in Sve2.PlatformNotSupported.cs. Also, there are extra definitions of MultiplyBySelectedScalarWideningEvenAndSubtract in Sve2.cs that don't have the index arg -- did you mean to get rid of this?

@snickolls-arm
Copy link
Contributor Author

I think you're missing some APIs in the .cs files, for example MultiplyWideningEvenAndSubtract in Sve2.PlatformNotSupported.cs. Also, there are extra definitions of MultiplyBySelectedScalarWideningEvenAndSubtract in Sve2.cs that don't have the index arg -- did you mean to get rid of this?

Thank you, yes these names were copied incorrectly in that file. I've pushed a fix.

amanasifkhalid
amanasifkhalid reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, just want to make sure emitter tests are still passing

@amanasifkhalid
Copy link
Contributor

Merging from main, now that we have SPMI collections

This was referenced Jul 16, 2025
Open
Closed
Closed
Closed
Closed
@a74nh a74nh mentioned this pull request Jul 16, 2025
Open
@a74nh
Copy link
Contributor

a74nh commented Jul 16, 2025

fyi, the saturate functions from the math list are mostly completed, but are blocked behind this PR getting merged because there's some work from this PR they need.

amanasifkhalid
amanasifkhalid approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, the saturate functions from the math list are mostly completed, but are blocked behind this PR getting merged because there's some work from this PR they need.

I'm gonna go ahead and merge this to unblock that work. I'll run the emitter tests locally and PR a fix, if needed.

@amanasifkhalid
Copy link
Contributor

/ba-g nativeaot and android-x64 build timeouts

@build-analysis build-analysis bot mentioned this pull request Jul 16, 2025
Closed
@amanasifkhalid amanasifkhalid merged commit 2de958d into dotnet:main Jul 16, 2025
159 of 165 checks passed
@a74nh
Copy link
Contributor

a74nh commented Jul 16, 2025

I'm gonna go ahead and merge this to unblock that work. I'll run the emitter tests locally and PR a fix, if needed.

Thanks. I think all it needs is to revert the changes in codegentest file from #116848 except for the block containing addhnb and addhnt

@build-analysis build-analysis bot mentioned this pull request Jul 16, 2025
Closed
@amanasifkhalid amanasifkhalid mentioned this pull request Jul 17, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@a74nh a74nh a74nh left review comments

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snickolls-arm @amanasifkhalid @a74nh