Skip to content

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Jul 14, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 14, 2025 21:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a crash in the AOT debugger by adding a null check for the TLS data before dereferencing tls->invoke.

  • Added !tls check in the jit_end function to guard against missing TLS data
  • Ensured profiling events are used as a fallback when TLS is unavailable
Comments suppressed due to low confidence (1)

src/mono/mono/component/debugger-agent.c:4143

  • Consider adding a comment explaining why tls can be NULL here and under which conditions this branch is taken, to improve maintainability and clarity.
			if (!CHECK_ICORDBG (TRUE) || !tls || tls->invoke == NULL) {

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @thaystg, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@thaystg
Copy link
Member Author

thaystg commented Jul 15, 2025

/ba-g failures on mono unrelated to PR changes

@thaystg thaystg merged commit 36eaeba into dotnet:main Jul 15, 2025
67 of 70 checks passed
@thaystg
Copy link
Member Author

thaystg commented Jul 21, 2025

/backport to release/9.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/16424385046

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants