JIT: Allow containment of CnsVec under GetElement node with non-const index #117562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Diffs show a couple of hits in tests, but it's not expected this is a common pattern. re: matching this optimization for |
tannergooding
approved these changes
Jul 12, 2025
Open
3 tasks
EgorBo
approved these changes
Jul 14, 2025
|
spmi replay failure is #117550 |
|
/ba-g unrelated android timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a pattern like
Vector128.GetElement(Vector128.Create(cns, cns, ...), noncns)to emit a read directly into the data section instead of loading the CnsVec, spilling it to the stack, and indexing into it there.This is added primarily to support a cast implementation to come in another PR.
(peeled from #116805)