Fix installing developer certificate in wasm Helix runs #117526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
This was referenced Jul 11, 2025
Open
akoeplinger
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Helix helper project to fix developer certificate installation in WASM Helix runs on Windows by exporting and importing a PFX instead of generating a new cert via PowerShell, and refreshes the related comment.
- Changed WindowsShell branch to use
dotnet dev-certs https --export-pathandImport-PfxCertificateinto LocalMachine\Root. - Updated the explanatory comment to mention the
--trustbehavior.
Comments suppressed due to low confidence (1)
src/libraries/sendtohelixhelp.proj:224
- Hard-coding a plaintext
PLACEHOLDERpassword and using percent-encoded semicolons can leak secrets and hinder readability. Consider sourcing the password from a secure MSBuild property or environment variable, and use standard semicolons for command separation.
<HelixCommand Condition="'$(InstallDevCerts)' == 'true' and '$(WindowsShell)' == 'true'">$(HelixCommand) powershell -command "dotnet dev-certs https --export-path devcerts.pfx --password PLACEHOLDER %3B $pw = ConvertTo-SecureString PLACEHOLDER -AsPlainText -Force %3B Import-PfxCertificate -FilePath devcerts.pfx -Password $pw -CertStoreLocation Cert:\LocalMachine\Root " && </HelixCommand>
lewing
approved these changes
Jul 11, 2025
This was referenced Jul 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#116695
Export the certificate generated by
dotnet dev-certsand import it via PowerShell rather than creating our own self-signed cert.