Update .slnx files due to recent P2P changes and add sfx.slnx #117494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update all .slnx files via `dotnet build src\libraries\slngen.proj` - Update the slngen infra - Add a sfx.slnx file that has the entire shared framework in it
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR updates all existing .slnx files to include explicit configurations for new build types and platforms, enhances each project entry with <BuildType>/<Build> (or <Platform>) mappings, and adds a new sfx.slnx for the shared framework.
- Added a
<Configurations>section (Checked, Debug, Release + platforms) to each solution file. - Expanded every
<Project>entry with per-configuration<BuildType>/<Build>or<Platform>settings. - Updated slngen infra and generated solution files via
dotnet build src\libraries\slngen.projand addedsfx.slnx.
Reviewed Changes
Copilot reviewed 23 out of 145 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/...EventLog/Microsoft.Extensions.Logging.EventLog.slnx | Added configurations and per-project build tags |
| src/libraries/...Logging.Debug/Microsoft.Extensions.Logging.Debug.slnx | Added configurations and per-project build tags |
| src/libraries/...Logging.Console/Microsoft.Extensions.Logging.Console.slnx | Added configurations and per-project build tags |
| src/libraries/...Logging.Configuration/Microsoft.Extensions.Logging.Configuration.slnx | Added configurations and per-project build tags |
| src/libraries/...Logging.Abstractions/Microsoft.Extensions.Logging.Abstractions.slnx | Added configurations and per-project build tags |
Comments suppressed due to low confidence (3)
src/libraries/Microsoft.Extensions.Logging.EventLog/Microsoft.Extensions.Logging.EventLog.slnx:321
- [nitpick] The CoreLib project block uses
<Platform>entries instead of the<BuildType>/<Build>pattern used by other projects. Consider aligning the configuration syntax or verifying that this mix of tags is intentional for correct solution configuration.
<Project Path="../../coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj">
src/libraries/Microsoft.Extensions.Logging.Debug/Microsoft.Extensions.Logging.Debug.slnx:265
- [nitpick] The CoreLib project entry uses
<Platform>tags while other library projects use<BuildType>/<Build>. Double-check that this variation is intentional and that the solution configurations still behave as expected.
<Project Path="../../coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj">
src/libraries/Microsoft.Extensions.Logging.Console/Microsoft.Extensions.Logging.Console.slnx:521
- [nitpick] This solution mixes
<Platform>entries for CoreLib with<BuildType>/<Build>entries for other projects. Consider unifying the configuration style or confirming that both syntaxes work together correctly.
<Project Path="../../coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj">
akoeplinger
reviewed
Jul 10, 2025
src/libraries/Microsoft.Extensions.Logging.EventLog/Microsoft.Extensions.Logging.EventLog.slnx
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Logging.EventLog/Microsoft.Extensions.Logging.EventLog.slnx
Show resolved
Hide resolved
akoeplinger
added
area-Infrastructure-libraries
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
This was referenced Jul 10, 2025
akoeplinger
approved these changes
Jul 14, 2025
This was referenced Jul 15, 2025
Open
|
/ba-g failures are unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reaction to 910f619
dotnet build src\libraries\slngen.projThis unblocks building the solution files inside VS again.