Ensure EINTR handling is much more consistent across the board
#117405
+1,012
−386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Excludes potential changes to libunwind
I skipped those which were already in infinite loops anyway
hamarb123
requested review from
lewing,
pavelsavara,
janvorli,
AaronRobinsonMSFT,
a team,
steveisok,
vitek-karas,
BrzVlad,
lateralusX and
MichalStrehovsky
as code owners
dotnet-policy-service
bot
added
the
community-contribution
- Excludes potential changes to libunwind
- Excludes potential changes to external libs: brotli, libunwind, libtracepoint-control-cpp - Excludes potential changes to "templates"
- Excludes potential changes to external lib libunwind - Excludes potential changes to "templates"
- Excludes potential changes to external libs: brotli, libtracepoint-control-cpp
- Excludes potential changes to external lib libunwind
- Excludes some potential changes to mono profiler, SystemNative_ReadEvents (seems broken maybe?)
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #116639 (comment)
Functions not yet done/checked:
select(I found ~3 candidates for this one, but I'm not certain if they should be changed or not, as they have a timeout parameter)Functions done are functions with
EINTRhandling in other places, such aspal_io.c, and some variants of those functions.Also addressed lack of partial operation handling for a number of cases.
I haven't checked new usages over the 3 months from the initial commit to where I did the merge.