[NativeAOT] Split ExternSymbolNode into two types for data and functions
#117346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
SingleAccretion
force-pushed
the
ILC-DataSym
branch
from
d6eb526 to
5d14360
Compare
This allows to distinguish the symbol type for a node with a simple type check.
SingleAccretion
force-pushed
the
ILC-DataSym
branch
from
5d14360 to
d62469a
Compare
This was referenced Jul 6, 2025
Open
MichalStrehovsky
approved these changes
Jul 8, 2025
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ExternSymbolNode.cs
Outdated
Show resolved
Hide resolved
…nalysis/ExternSymbolNode.cs
|
Ooops, I've noticed a mistake that somehow slipped past me in the original change; fixed in the last commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream (for WASM), we need to know the kind of symbol we're generating for each node. For extern symbols, we have so far been relying a bit a hack, which has recently finally proven itself insufficient. The correct fix for this problem is in this change, but it would have been rather expensive to maintain it conflict-free downstream and it is not WASM-specific otherwise, so I am upstreaming it.