Revert "Replace CordbProcess::GetSharedDomain with GetAppDomain"
#117221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
approved these changes
Jul 1, 2025
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
There was a problem hiding this comment.
Pull Request Overview
Reverts previous PR (#117037) that replaced thread-specific domain lookup with a single-domain model, restoring per-thread GetCurrentAppDomain behavior and introducing a shared default AppDomain fallback.
- Updated
IDacDbiInterfaceand its implementation to take avmThreadparameter forGetCurrentAppDomain. - Modified all callers in
CordbThread,CordbProcess, and related classes to pass their thread token. - Added
GetSharedAppDomain,m_sharedAppDomainfallback, andUpdateThreadsForAdUnloadto manage default domain unloading and thread cleanup.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/debug/inc/dacdbiinterface.h | Changed GetCurrentAppDomain to accept a vmThread argument. |
| src/coreclr/debug/di/rsthread.cpp | Updated calls to GetCurrentAppDomain with vmThread. |
| src/coreclr/debug/di/rspriv.h | Adjusted CacheAssembly overload signatures; renamed GetAppDomain. |
| src/coreclr/debug/di/rsappdomain.cpp | Refactored assembly caching/removal to use VMPTR_DomainAssembly. |
| src/coreclr/debug/di/process.cpp | Added m_sharedAppDomain, GetSharedAppDomain, and thread cleanup. |
| src/coreclr/debug/di/module.cpp | Fallback to GetSharedAppDomain when no DomainAssembly is available. |
| src/coreclr/debug/daccess/dacdbiimpl.h/.cpp | Added thread-parameter overload for GetCurrentAppDomain. |
elinor-fung
approved these changes
Jul 1, 2025
|
#117221 is the fix for assemblies not being found in the cache. Assuming this goes in first, I'll update that to be the revert of the revert. |
elinor-fung
added a commit
to elinor-fung/runtime
that referenced
this pull request
Jul 2, 2025
…otnet#117037)" (dotnet#117221) This reverts commit a3929e2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #117037 This breaks debugging basics.
Notably, enumerating the list of assemblies results in an infinite loop as it builds more and more CorDbAssembly objects.