Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 24, 2025 14:17
@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issues in native AOT outerloop runs by improving type resolution in the AOT compiler. The key change is the update to the type retrieval logic in TypeMapMetadata.cs to use GetObject with NotFoundBehavior.ReturnNull and an added null-check to safely skip unresolved types.

Comments suppressed due to low confidence (1)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypeMapMetadata.cs:168

  • The update to use NotFoundBehavior.ReturnNull is appropriate; ensure that the null-check and early continue fully address any downstream issues when the attribute type is unresolved.
                    TypeDesc type = (TypeDesc)currentAssembly.GetObject(attributeType, NotFoundBehavior.ReturnNull);

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/ba-g timeout in networking test

@MichalStrehovsky MichalStrehovsky merged commit ee293c3 into main Jun 24, 2025
112 of 117 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch June 24, 2025 21:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants