-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Try fixing native AOT outerloop runs #116961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run runtime-nativeaot-outerloop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issues in native AOT outerloop runs by improving type resolution in the AOT compiler. The key change is the update to the type retrieval logic in TypeMapMetadata.cs to use GetObject with NotFoundBehavior.ReturnNull and an added null-check to safely skip unresolved types.
Comments suppressed due to low confidence (1)
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypeMapMetadata.cs:168
- The update to use NotFoundBehavior.ReturnNull is appropriate; ensure that the null-check and early continue fully address any downstream issues when the attribute type is unresolved.
TypeDesc type = (TypeDesc)currentAssembly.GetObject(attributeType, NotFoundBehavior.ReturnNull);
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g timeout in networking test |
No description provided.