dont try to zero-out mapping if VirtualAlloc fails #116794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a potential access violation/deadlock by preventing the release mapping if VirtualAlloc fails.
- Adds a NULL check after calling VirtualAlloc to ensure that mapping is not released when allocation fails.
- Prevents subsequent operations on an invalid pointer, avoiding a crash.
Member
|
The PR title is a bit misleading - it should rather be "don't try to zero out mapping if VirtualAlloc fails". That's what was causing the problem. |
mangod9
changed the title
Member
Author
sure, changed the title. Thx. |
janvorli
approved these changes
Jun 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been one case where this leads to an AV / deadlock.