Skip to content

[Mono][Win] Incorrect decomposition of simd calls #116433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025
Merged

[Mono][Win] Incorrect decomposition of simd calls #116433

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f860ee2
Incorrect decomposition of simd calls
saitama951 Jun 9, 2025
98fd618
add missing semicolon
saitama951 Jun 11, 2025
6a70d95
Merge branch 'main' into main
saitama951 Jul 2, 2025
b804fa0
Merge branch 'main' into main
lewing Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions src/mono/mono/mini/simd-intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6717,21 +6717,29 @@ mono_emit_common_intrinsics (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSi
static gboolean
decompose_vtype_opt_uses_simd_intrinsics (MonoCompile *cfg, MonoInst *ins)
{
if (cfg->uses_simd_intrinsics)
return TRUE;
switch (ins->opcode) {
case OP_XCALL:
case OP_XCALL_REG:
case OP_XCALL_MEMBASE:
return FALSE;
}

if (cfg->uses_simd_intrinsics)
return TRUE;

switch (ins->opcode) {
case OP_XMOVE:
case OP_XZERO:
case OP_XPHI:
case OP_LOADX_MEMBASE:
case OP_LOADX_ALIGNED_MEMBASE:
case OP_STOREX_MEMBASE:
case OP_STOREX_ALIGNED_MEMBASE_REG:
return TRUE;
default:
return FALSE;
}

switch (ins->opcode) {
case OP_XMOVE:
case OP_XZERO:
case OP_XPHI:
case OP_LOADX_MEMBASE:
case OP_LOADX_ALIGNED_MEMBASE:
case OP_STOREX_MEMBASE:
case OP_STOREX_ALIGNED_MEMBASE_REG:
return TRUE;
default:
return FALSE;
}
}

static void
Expand Down
Loading