Skip to content

[wasm] Consolidate native build logic for WASM #116390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 27, 2025
Merged

[wasm] Consolidate native build logic for WASM #116390

merged 11 commits into from
Aug 27, 2025

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Jun 6, 2025 •
edited
Loading

  1. Make the Windows and not-Windows logic match.
  2. Remove unnecessary arguments.
  3. Simplify.

Fixes #119100.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 6, 2025
@build-analysis build-analysis bot mentioned this pull request Jun 6, 2025
Closed
@SingleAccretion SingleAccretion marked this pull request as ready for review June 7, 2025 11:52
@SingleAccretion SingleAccretion added the arch-wasm WebAssembly architecture label Jun 7, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@lewing lewing requested review from radekdoulik June 16, 2025 14:40
This was referenced Jun 25, 2025
Closed
Closed
Closed
Open
@SingleAccretion SingleAccretion force-pushed the Wasm-Build-Cleanup branch 2 times, most recently from 19991f3 to 02d7aee Compare June 26, 2025 13:03
@build-analysis build-analysis bot mentioned this pull request Jun 26, 2025
Closed
@SingleAccretion SingleAccretion marked this pull request as draft July 11, 2025 10:19
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

This was referenced Aug 14, 2025
Closed
Closed
Closed
Closed
This was referenced Aug 15, 2025
Open
Closed
@SingleAccretion SingleAccretion marked this pull request as ready for review August 15, 2025 20:14
@SingleAccretion
Copy link
Contributor Author

@dotnet/wasm-eng

@pavelsavara
Copy link
Member

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara reviewed Aug 26, 2025
View reviewed changes
@pavelsavara
Copy link
Member

wasi build is broken at the moment, I filled #119100

@SingleAccretion
Copy link
Contributor Author

wasi build is broken at the moment, I filled

Yeah, fixing in progress...

@pavelsavara pavelsavara mentioned this pull request Aug 26, 2025
Merged
@SingleAccretion
Copy link
Contributor Author

The runtime-wasm failures looked pre-existing (checked against https://dev.azure.com/dnceng-public/public/_build/results?buildId=1130446&view=ms.vss-test-web.build-test-results-tab). With the pushed WASI build fixes we can take another turn.

jkotas
jkotas reviewed Aug 26, 2025
View reviewed changes
@pavelsavara
Copy link
Member

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Aug 26, 2025
Closed
@SingleAccretion
Copy link
Contributor Author

The latest run looks clean modulo preexisting failures.

@pavelsavara
Copy link
Member

The latest run looks clean modulo preexisting failures.

Yes. There is some issue with runtime config which is probably my fault.
I filled #119136
That should not be blocking this PR

@pavelsavara pavelsavara merged commit 229aaef into dotnet:main Aug 27, 2025
163 of 169 checks passed
@pavelsavara
Copy link
Member

thanks @SingleAccretion !

@pavelsavara pavelsavara self-assigned this Aug 27, 2025
@SingleAccretion SingleAccretion deleted the Wasm-Build-Cleanup branch August 31, 2025 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas left review comments

@pavelsavara pavelsavara pavelsavara approved these changes

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@steveisok steveisok Awaiting requested review from steveisok

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@maraf maraf Awaiting requested review from maraf

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-Build-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WASI] build is broken

3 participants

@SingleAccretion @pavelsavara @jkotas