Skip to content

Conversation

filipnavara
Copy link
Member

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 4, 2025
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@huoyaoyuan
Copy link
Member

There are a bit more dead patterns: #103533 (comment)

A little portion of dead code accessing ESP+offset is not removed in stublinkerx86.

Can we figure out what are alive now?

@filipnavara
Copy link
Member Author

I removed bulk of the code in #115339 and now I checked every remaining method if it's used or not.

@filipnavara
Copy link
Member Author

On second look I found more things to remove. We can likely remove the single usage of X86EmitNearJump too and that will make another big chunk go away.

@filipnavara filipnavara requested a review from jkotas June 5, 2025 06:19
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 259204a into dotnet:main Jun 6, 2025
94 of 96 checks passed
@filipnavara filipnavara deleted the x86-dead-code branch June 6, 2025 06:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants