Delete DacVirtualUnwind #116286
Merged
Delete DacVirtualUnwind #116286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the obsolete DacVirtualUnwind functionality, eliminating both its declaration and implementation for TARGET_UNIX builds.
- Removed DacVirtualUnwind declaration from src/coreclr/inc/daccess.h.
- Removed DacVirtualUnwind implementation and related helper functions from src/coreclr/debug/daccess/dacfn.cpp.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/inc/daccess.h | Removed DacVirtualUnwind function declaration |
| src/coreclr/debug/daccess/dacfn.cpp | Removed DacVirtualUnwind implementation and associated code |
|
Missed in #116085 |
|
Tagging subscribers to this area: @tommcdon |
davidwrighton
approved these changes
Jun 4, 2025
max-charlamb
reviewed
Jun 4, 2025
jkotas
commented
Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.