JIT: avoid some unnecessary retyping in escape analysis #116277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may discover a TYP_BYREF local can point to stack objects, in which case it will remain a TYP_BYREF local, so no retyping is needed. Fixes dotnet#116213
github-actions
bot
added
the
area-CodeGen-coreclr
|
@jakobbotsch PTAL No diffs |
There was a problem hiding this comment.
Pull Request Overview
This PR adds logic to skip retyping for locals that are already TYP_BYREF and point to stack objects, clearing their tracked status instead.
- Introduces an
elsebranch inRewriteUsesto log when no retyping is needed and clearlvTracked. - Avoids unnecessary retyping work during escape analysis.
Comments suppressed due to low confidence (1)
src/coreclr/jit/objectalloc.cpp:2809
- Consider adding a unit test or JIT validation to exercise this new else branch, ensuring that when no retyping is needed,
lvTrackedis correctly cleared without side effects.
lclVarDsc->lvTracked = 0;
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
approved these changes
Jun 3, 2025
|
/ba-g unrelated installer build and test failure. |
Open
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may discover a TYP_BYREF local can point to stack objects, in which case it will remain a TYP_BYREF local, so no retyping is needed.
Fixes #116213