Make sure binder gets enumerated #116164
Open
Make sure binder gets enumerated #116164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the binder is properly enumerated during memory enumeration by invoking EnumMemoryRegions on g_CoreLib, fixing a latent fault when performing dumpobj.
- Added a
CATCH_ALL_EXCEPT_RETHROW_COR_E_OPERATIONCANCELLEDblock to callEnumMemoryRegionsong_CoreLib. - Updated the memory enumeration sequence to include the binder lookup.
|
Tagging subscribers to this area: @tommcdon |
|
Does this mean that we cannot depend on the static readonly data in the binary to be available when evaluating minidumps under the debugger? The static arrays like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime fix for dotnet/diagnostics#5491
#113907 surfaced a latent bug - we never used the binder for type-lookup-by-name.
m_pClassesand friends live in loader heaps, and those are already collected. However, asking for the RCW table by field name in the COM wrappers object field surfaces this issue: while doingdumpobjwe request RCW data, and if such access has never happened at runtime through the binder we will fault in the DAC.