[browser] Remove rest of StartupMemoryCache #115878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
linkable-framework
Co-authored-by: pavelsavara <[email protected]>
Copilot
AI
changed the title
[WIP] [browser] remove rest of StartupMemoryCache
[browser] Remove rest of StartupMemoryCache
May 22, 2025
Copilot finished work on behalf of
pavelsavara
May 22, 2025 06:49
Contributor
There was a problem hiding this comment.
Pull Request Overview
Remove the remaining vestiges of the deprecated StartupMemoryCache feature across tasks, sample code, and build targets.
- Dropped the
StartupMemoryCacheproperty and its usage fromGenerateWasmBootJson - Removed the
startupMemoryCachefield fromBootJsonData - Cleared the sample JS and MSBuild targets of related configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs | Removed StartupMemoryCache parameter and assignment |
| src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonData.cs | Deleted the nullable startupMemoryCache property |
| src/mono/sample/wasm/browser-advanced/main.js | Eliminated the startupMemoryCache entry in config |
| src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets | Cleared MSBuild properties for startup memory cache |
ilonatommy
approved these changes
May 22, 2025
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pavelsavara <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the remaining parts of the
StartupMemoryCachefeature, which is no longer needed:startupMemoryCacheproperty fromBootJsonDataclass insrc/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonData.csstartupMemoryCacheconfiguration insrc/mono/sample/wasm/browser-advanced/main.jsStartupMemoryCacheparameter fromGenerateWasmBootJsontask insrc/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs_BlazorWebAssemblyStartupMemoryCacheproperty and its usage in MSBuild filesrc/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targetsThese changes clean up the codebase by removing a deprecated feature that is no longer used in the WebAssembly runtime.
Fixes #115107.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.