Skip to content

Implement SVE2 ShiftArithmeticRounded, ShiftArithmeticRoundedSaturate, ShiftArithmeticSaturate #115774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

Implement SVE2 ShiftArithmeticRounded, ShiftArithmeticRoundedSaturate, ShiftArithmeticSaturate #115774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7b9c3d
Implement SVE2 ShiftArithmeticRounded, ShiftArithmeticRoundedSaturate…
snickolls-arm May 14, 2025
bff8c11
Improve formatting
snickolls-arm May 21, 2025
9ad2c4d
Merge branch 'main' of https://github.com/dotnet/runtime into sve2-sh…
snickolls-arm Jun 3, 2025
4a3a51c
Add correction for range of predicate registers
snickolls-arm Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/coreclr/jit/hwintrinsiclistarm64sve.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,9 @@ HARDWARE_INTRINSIC(Sve2, BitwiseClearXor,
HARDWARE_INTRINSIC(Sve2, BitwiseSelect, -1, 3, {INS_sve_bsl, INS_sve_bsl, INS_sve_bsl, INS_sve_bsl, INS_sve_bsl, INS_sve_bsl, INS_sve_bsl, INS_sve_bsl, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_SpecialCodeGen|HW_Flag_HasRMWSemantics)
HARDWARE_INTRINSIC(Sve2, BitwiseSelectLeftInverted, -1, 3, {INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_SpecialCodeGen|HW_Flag_HasRMWSemantics)
HARDWARE_INTRINSIC(Sve2, BitwiseSelectRightInverted, -1, 3, {INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_SpecialCodeGen|HW_Flag_HasRMWSemantics)
HARDWARE_INTRINSIC(Sve2, ShiftArithmeticRounded, -1, -1, {INS_sve_srshl, INS_invalid, INS_sve_srshl, INS_invalid, INS_sve_srshl, INS_invalid, INS_sve_srshl, INS_invalid, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_EmbeddedMaskedOperation|HW_Flag_HasRMWSemantics|HW_Flag_LowMaskedOperation)
HARDWARE_INTRINSIC(Sve2, ShiftArithmeticRoundedSaturate, -1, -1, {INS_sve_sqrshl, INS_invalid, INS_sve_sqrshl, INS_invalid, INS_sve_sqrshl, INS_invalid, INS_sve_sqrshl, INS_invalid, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_EmbeddedMaskedOperation|HW_Flag_HasRMWSemantics|HW_Flag_LowMaskedOperation)
HARDWARE_INTRINSIC(Sve2, ShiftArithmeticSaturate, -1, -1, {INS_sve_sqshl, INS_invalid, INS_sve_sqshl, INS_invalid, INS_sve_sqshl, INS_invalid, INS_sve_sqshl, INS_invalid, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_EmbeddedMaskedOperation|HW_Flag_HasRMWSemantics|HW_Flag_LowMaskedOperation)
HARDWARE_INTRINSIC(Sve2, ShiftLeftAndInsert, -1, 3, {INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_invalid, INS_invalid}, HW_Category_ShiftLeftByImmediate, HW_Flag_Scalable|HW_Flag_HasImmediateOperand|HW_Flag_HasRMWSemantics)
HARDWARE_INTRINSIC(Sve2, Xor, -1, 3, {INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_SpecialCodeGen|HW_Flag_HasRMWSemantics)
HARDWARE_INTRINSIC(Sve2, XorRotateRight, -1, 3, {INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_invalid, INS_invalid}, HW_Category_ShiftRightByImmediate, HW_Flag_Scalable|HW_Flag_HasRMWSemantics|HW_Flag_HasImmediateOperand)
Expand Down
82 changes: 82 additions & 0 deletions ...ies/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.PlatformNotSupported.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,88 @@ internal Arm64() { }
/// </summary>
public static Vector<ulong> BitwiseSelectRightInverted(Vector<ulong> select, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }


// Rounding shift left

/// <summary>
/// svint16_t svrshl[_s16]_m(svbool_t pg, svint16_t op1, svint16_t op2)
/// SRSHL Ztied1.H, Pg/M, Ztied1.H, Zop2.H
/// </summary>
public static unsafe Vector<short> ShiftArithmeticRounded(Vector<short> value, Vector<short> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint32_t svrshl[_s32]_m(svbool_t pg, svint32_t op1, svint32_t op2)
/// SRSHL Ztied1.S, Pg/M, Ztied1.S, Zop2.S
/// </summary>
public static unsafe Vector<int> ShiftArithmeticRounded(Vector<int> value, Vector<int> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint64_t svrshl[_s64]_m(svbool_t pg, svint64_t op1, svint64_t op2)
/// SRSHL Ztied1.D, Pg/M, Ztied1.D, Zop2.D
/// </summary>
public static unsafe Vector<long> ShiftArithmeticRounded(Vector<long> value, Vector<long> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint8_t svrshl[_s8]_m(svbool_t pg, svint8_t op1, svint8_t op2)
/// SRSHL Ztied1.B, Pg/M, Ztied1.B, Zop2.B
/// </summary>
public static unsafe Vector<sbyte> ShiftArithmeticRounded(Vector<sbyte> value, Vector<sbyte> count) { throw new PlatformNotSupportedException(); }


// Saturating rounding shift left

/// <summary>
/// svint16_t svqrshl[_s16]_m(svbool_t pg, svint16_t op1, svint16_t op2)
/// SQRSHL Ztied1.H, Pg/M, Ztied1.H, Zop2.H
/// </summary>
public static unsafe Vector<short> ShiftArithmeticRoundedSaturate(Vector<short> value, Vector<short> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint32_t svqrshl[_s32]_m(svbool_t pg, svint32_t op1, svint32_t op2)
/// SQRSHL Ztied1.S, Pg/M, Ztied1.S, Zop2.S
/// </summary>
public static unsafe Vector<int> ShiftArithmeticRoundedSaturate(Vector<int> value, Vector<int> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint64_t svqrshl[_s64]_m(svbool_t pg, svint64_t op1, svint64_t op2)
/// SQRSHL Ztied1.D, Pg/M, Ztied1.D, Zop2.D
/// </summary>
public static unsafe Vector<long> ShiftArithmeticRoundedSaturate(Vector<long> value, Vector<long> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint8_t svqrshl[_s8]_m(svbool_t pg, svint8_t op1, svint8_t op2)
/// SQRSHL Ztied1.B, Pg/M, Ztied1.B, Zop2.B
/// </summary>
public static unsafe Vector<sbyte> ShiftArithmeticRoundedSaturate(Vector<sbyte> value, Vector<sbyte> count) { throw new PlatformNotSupportedException(); }


// Saturating shift left

/// <summary>
/// svint16_t svqshl[_s16]_m(svbool_t pg, svint16_t op1, svint16_t op2)
/// SQSHL Ztied1.H, Pg/M, Ztied1.H, Zop2.H
/// </summary>
public static unsafe Vector<short> ShiftArithmeticSaturate(Vector<short> value, Vector<short> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint32_t svqshl[_s32]_m(svbool_t pg, svint32_t op1, svint32_t op2)
/// SQSHL Ztied1.S, Pg/M, Ztied1.S, Zop2.S
/// </summary>
public static unsafe Vector<int> ShiftArithmeticSaturate(Vector<int> value, Vector<int> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint64_t svqshl[_s64]_m(svbool_t pg, svint64_t op1, svint64_t op2)
/// SQSHL Ztied1.D, Pg/M, Ztied1.D, Zop2.D
/// </summary>
public static unsafe Vector<long> ShiftArithmeticSaturate(Vector<long> value, Vector<long> count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint8_t svqshl[_s8]_m(svbool_t pg, svint8_t op1, svint8_t op2)
/// SQSHL Ztied1.B, Pg/M, Ztied1.B, Zop2.B
/// </summary>
public static unsafe Vector<sbyte> ShiftArithmeticSaturate(Vector<sbyte> value, Vector<sbyte> count) { throw new PlatformNotSupportedException(); }


// Shift left and insert

/// <summary>
Expand Down
82 changes: 82 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,88 @@ internal Arm64() { }
/// </summary>
public static unsafe Vector<ulong> BitwiseSelectRightInverted(Vector<ulong> select, Vector<ulong> left, Vector<ulong> right) => BitwiseSelectRightInverted(select, left, right);


// Rounding shift left

/// <summary>
/// svint16_t svrshl[_s16]_m(svbool_t pg, svint16_t op1, svint16_t op2)
/// SRSHL Ztied1.H, Pg/M, Ztied1.H, Zop2.H
/// </summary>
public static unsafe Vector<short> ShiftArithmeticRounded(Vector<short> value, Vector<short> count) => ShiftArithmeticRounded(value, count);

/// <summary>
/// svint32_t svrshl[_s32]_m(svbool_t pg, svint32_t op1, svint32_t op2)
/// SRSHL Ztied1.S, Pg/M, Ztied1.S, Zop2.S
/// </summary>
public static unsafe Vector<int> ShiftArithmeticRounded(Vector<int> value, Vector<int> count) => ShiftArithmeticRounded(value, count);

/// <summary>
/// svint64_t svrshl[_s64]_m(svbool_t pg, svint64_t op1, svint64_t op2)
/// SRSHL Ztied1.D, Pg/M, Ztied1.D, Zop2.D
/// </summary>
public static unsafe Vector<long> ShiftArithmeticRounded(Vector<long> value, Vector<long> count) => ShiftArithmeticRounded(value, count);

/// <summary>
/// svint8_t svrshl[_s8]_m(svbool_t pg, svint8_t op1, svint8_t op2)
/// SRSHL Ztied1.B, Pg/M, Ztied1.B, Zop2.B
/// </summary>
public static unsafe Vector<sbyte> ShiftArithmeticRounded(Vector<sbyte> value, Vector<sbyte> count) => ShiftArithmeticRounded(value, count);


// Saturating rounding shift left

/// <summary>
/// svint16_t svqrshl[_s16]_m(svbool_t pg, svint16_t op1, svint16_t op2)
/// SQRSHL Ztied1.H, Pg/M, Ztied1.H, Zop2.H
/// </summary>
public static unsafe Vector<short> ShiftArithmeticRoundedSaturate(Vector<short> value, Vector<short> count) => ShiftArithmeticRoundedSaturate(value, count);

/// <summary>
/// svint32_t svqrshl[_s32]_m(svbool_t pg, svint32_t op1, svint32_t op2)
/// SQRSHL Ztied1.S, Pg/M, Ztied1.S, Zop2.S
/// </summary>
public static unsafe Vector<int> ShiftArithmeticRoundedSaturate(Vector<int> value, Vector<int> count) => ShiftArithmeticRoundedSaturate(value, count);

/// <summary>
/// svint64_t svqrshl[_s64]_m(svbool_t pg, svint64_t op1, svint64_t op2)
/// SQRSHL Ztied1.D, Pg/M, Ztied1.D, Zop2.D
/// </summary>
public static unsafe Vector<long> ShiftArithmeticRoundedSaturate(Vector<long> value, Vector<long> count) => ShiftArithmeticRoundedSaturate(value, count);

/// <summary>
/// svint8_t svqrshl[_s8]_m(svbool_t pg, svint8_t op1, svint8_t op2)
/// SQRSHL Ztied1.B, Pg/M, Ztied1.B, Zop2.B
/// </summary>
public static unsafe Vector<sbyte> ShiftArithmeticRoundedSaturate(Vector<sbyte> value, Vector<sbyte> count) => ShiftArithmeticRoundedSaturate(value, count);


// Saturating shift left

/// <summary>
/// svint16_t svqshl[_s16]_m(svbool_t pg, svint16_t op1, svint16_t op2)
/// SQSHL Ztied1.H, Pg/M, Ztied1.H, Zop2.H
/// </summary>
public static unsafe Vector<short> ShiftArithmeticSaturate(Vector<short> value, Vector<short> count) => ShiftArithmeticSaturate(value, count);

/// <summary>
/// svint32_t svqshl[_s32]_m(svbool_t pg, svint32_t op1, svint32_t op2)
/// SQSHL Ztied1.S, Pg/M, Ztied1.S, Zop2.S
/// </summary>
public static unsafe Vector<int> ShiftArithmeticSaturate(Vector<int> value, Vector<int> count) => ShiftArithmeticSaturate(value, count);

/// <summary>
/// svint64_t svqshl[_s64]_m(svbool_t pg, svint64_t op1, svint64_t op2)
/// SQSHL Ztied1.D, Pg/M, Ztied1.D, Zop2.D
/// </summary>
public static unsafe Vector<long> ShiftArithmeticSaturate(Vector<long> value, Vector<long> count) => ShiftArithmeticSaturate(value, count);

/// <summary>
/// svint8_t svqshl[_s8]_m(svbool_t pg, svint8_t op1, svint8_t op2)
/// SQSHL Ztied1.B, Pg/M, Ztied1.B, Zop2.B
/// </summary>
public static unsafe Vector<sbyte> ShiftArithmeticSaturate(Vector<sbyte> value, Vector<sbyte> count) => ShiftArithmeticSaturate(value, count);


// Shift left and insert

/// <summary>
Expand Down
12 changes: 12 additions & 0 deletions src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6071,6 +6071,18 @@ internal Arm64() { }
public static System.Numerics.Vector<ushort> BitwiseSelectRightInverted(System.Numerics.Vector<ushort> select, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
public static System.Numerics.Vector<uint> BitwiseSelectRightInverted(System.Numerics.Vector<uint> select, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
public static System.Numerics.Vector<ulong> BitwiseSelectRightInverted(System.Numerics.Vector<ulong> select, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
public static System.Numerics.Vector<short> ShiftArithmeticRounded(System.Numerics.Vector<short> value, System.Numerics.Vector<short> count) { throw null; }
public static System.Numerics.Vector<int> ShiftArithmeticRounded(System.Numerics.Vector<int> value, System.Numerics.Vector<int> count) { throw null; }
public static System.Numerics.Vector<long> ShiftArithmeticRounded(System.Numerics.Vector<long> value, System.Numerics.Vector<long> count) { throw null; }
public static System.Numerics.Vector<sbyte> ShiftArithmeticRounded(System.Numerics.Vector<sbyte> value, System.Numerics.Vector<sbyte> count) { throw null; }
public static System.Numerics.Vector<short> ShiftArithmeticRoundedSaturate(System.Numerics.Vector<short> value, System.Numerics.Vector<short> count) { throw null; }
public static System.Numerics.Vector<int> ShiftArithmeticRoundedSaturate(System.Numerics.Vector<int> value, System.Numerics.Vector<int> count) { throw null; }
public static System.Numerics.Vector<long> ShiftArithmeticRoundedSaturate(System.Numerics.Vector<long> value, System.Numerics.Vector<long> count) { throw null; }
public static System.Numerics.Vector<sbyte> ShiftArithmeticRoundedSaturate(System.Numerics.Vector<sbyte> value, System.Numerics.Vector<sbyte> count) { throw null; }
public static System.Numerics.Vector<short> ShiftArithmeticSaturate(System.Numerics.Vector<short> value, System.Numerics.Vector<short> count) { throw null; }
public static System.Numerics.Vector<int> ShiftArithmeticSaturate(System.Numerics.Vector<int> value, System.Numerics.Vector<int> count) { throw null; }
public static System.Numerics.Vector<long> ShiftArithmeticSaturate(System.Numerics.Vector<long> value, System.Numerics.Vector<long> count) { throw null; }
public static System.Numerics.Vector<sbyte> ShiftArithmeticSaturate(System.Numerics.Vector<sbyte> value, System.Numerics.Vector<sbyte> count) { throw null; }
public static System.Numerics.Vector<byte> ShiftLeftAndInsert(System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right, [ConstantExpected] byte shift) { throw null; }
public static System.Numerics.Vector<short> ShiftLeftAndInsert(System.Numerics.Vector<short> left, System.Numerics.Vector<short> right, [ConstantExpected] byte shift) { throw null; }
public static System.Numerics.Vector<int> ShiftLeftAndInsert(System.Numerics.Vector<int> left, System.Numerics.Vector<int> right, [ConstantExpected] byte shift) { throw null; }
Expand Down
Loading
Loading