-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Restore personality routine outside Windows #115729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`IsIPInEpilog` depends on this to exist. This breaks hijacking outside Windows.
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
/azp run runtime-coreclr jitstress |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Jan Kotas <[email protected]>
/azp run runtime-coreclr jitstress |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks! |
/ba-g Installer build and test actually succeeded when looking at the console log manually (https://helix.dot.net/api/jobs/87aee799-4b70-4745-9564-0daadc53e3d0/workitems/HostActivation.Tests?api-version=2019-06-17). The other failure is a build failure being fixed by #115767 |
`IsIPInEpilog` depends on this to exist. Without it, hijacking is broken outside Windows.
#115083 removed this outside Windows based on the discussion #115083 (comment).
But
IsIPInEpilog
seems to depend on this to be set:runtime/src/coreclr/vm/excep.cpp
Lines 6867 to 6880 in a76c008
This breaks hijacking outside Windows.
Fix #115321