[browser] fix WasmProfilers vs WasmPerfTracing warning #115727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
There was a problem hiding this comment.
Pull Request Overview
This PR moves the WasmProfilers vs WasmPerfTracing/WasmPerfInstrumentation error checks from BrowserWasmApp.targets into the common targets file and adjusts the error messaging accordingly.
- Moved duplicated error validations from BrowserWasmApp.targets.
- Added or updated error conditions in WasmApp.Common.targets to standardize the behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mono/wasm/build/WasmApp.Common.targets | Added error conditions for incompatible WasmProfilers settings. |
| src/mono/browser/build/BrowserWasmApp.targets | Removed redundant error conditions. |
lewing
approved these changes
May 20, 2025
maraf
approved these changes
May 20, 2025
|
/ba-g CI timeout |
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_GetWasmGenerateAppBundleDependenciesonly works in-tree