Ensure that NI_SSE2_Extract and NI_SSE41_Extract are simdSize=16 #115580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the NI_SSE2_Extract and NI_SSE41_Extract intrinsics are handled with a SIMD size of 16 and updates the lowering logic accordingly.
- Adds a test project and corresponding test file to validate the intrinsic behavior.
- Updates the lowering logic in coreclr/jit/lowerxarch.cpp with simdSize adjustments and new handling for specific intrinsic cases.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tests/JIT/Regression/JitBlue/Runtime_115493/Runtime_115493.csproj | New test project file enabling the test compilation and execution. |
| src/tests/JIT/Regression/JitBlue/Runtime_115493/Runtime_115493.cs | Test file validating the SIMD intrinsic extraction behavior. |
| src/coreclr/jit/lowerxarch.cpp | Updates to set the SIMD size to 16 and added conditions for additional intrinsic cases. |
Member
Author
|
CC. @dotnet/jit-contrib, @kunalspathak for review |
tannergooding
force-pushed
the
fix-115493
branch
2 times, most recently
from
bd61fa1 to
8fca552
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #115493