Skip to content

Use whole-archive to ensure DAC exports are preserved #115309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Use whole-archive to ensure DAC exports are preserved #115309

merged 1 commit into from
May 5, 2025

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented May 5, 2025

Fixes #115245

  • daccess and corguids archives are needed for DAC initialization
  • Preserving PAL in DAC is needed for DBI to use a consistent PAL.

@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 18:36
Copilot
Copilot AI reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/coreclr/dlls/mscordac/CMakeLists.txt: Language not supported

@hoyosjs hoyosjs requested a review from mikem8361 May 5, 2025 18:36
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@hoyosjs hoyosjs mentioned this pull request May 5, 2025
Merged
@build-analysis build-analysis bot mentioned this pull request May 5, 2025
Closed
@hoyosjs hoyosjs merged commit de08ba0 into main May 5, 2025
93 of 96 checks passed
@hoyosjs hoyosjs deleted the hoyosjs-patch-2 branch May 5, 2025 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

+1 more reviewer

@mikem8361 mikem8361 mikem8361 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hoyosjs hoyosjs

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[createdump] InitializeDAC: GetProcAddress(CLRDataCreateInstance) Failure

3 participants

@hoyosjs @jkoritzinsky @mikem8361