Skip to content

Conversation

am11
Copy link
Member

@am11 am11 commented May 3, 2025

Trying to re-fix #114842 after --bootstrap change.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 3, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 3, 2025
@am11 am11 added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 3, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that we still used the bootstrapped ILC and bootstrapped libs? And the bootstrapped single file host if we were to be targeting a platform where NAOT isn't supported?

@am11
Copy link
Member Author

am11 commented May 4, 2025

Can you confirm that we still used the bootstrapped ILC and bootstrapped libs?

I think so based on --bootstrap builds followed by AOT smoke tests are passing for community platforms:

And the bootstrapped single file host if we were to be targeting a platform where NAOT isn't supported?

  1. Community platforms are building _inbuilt using PublishSingleFile just like official platforms.
  2. All desktop OS (other than illumos and haiku) are supporting AOT these days.

so I think we are covered.

@am11 am11 requested a review from jkoritzinsky May 4, 2025 02:20
@jkoritzinsky
Copy link
Member

/ba-g failures unrelated and build analysis is stuck

@jkoritzinsky jkoritzinsky merged commit 4786752 into dotnet:main May 5, 2025
144 of 149 checks passed
@am11 am11 deleted the patch-39 branch May 5, 2025 05:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Source Build Validation legs are failing

3 participants