Skip to content

Conversation

AaronRobinsonMSFT
Copy link
Member

Introduced by #113715

Fixes #114696

See #114696 (comment)

Thanks @tfenise

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-buffers
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review April 29, 2025 22:12
@Copilot Copilot AI review requested due to automatic review settings April 29, 2025 22:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a regression caused by overload resolution by updating the internal API calls.

  • Updated the call in SpanHelpers.ByteMemOps.cs to use Buffer.MemmoveInternal.
  • Renamed the internal method in Buffer.cs from Memmove to MemmoveInternal to resolve overload ambiguity.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/libraries/System.Private.CoreLib/src/System/SpanHelpers.ByteMemOps.cs Updated the method call to use the newly renamed internal method.
src/libraries/System.Private.CoreLib/src/System/Buffer.cs Renamed the method to MemmoveInternal to clear up overload resolution issues.
Comments suppressed due to low confidence (1)

src/libraries/System.Private.CoreLib/src/System/Buffer.cs:130

  • Verify that renaming the internal method from 'Memmove' to 'MemmoveInternal' clarifies its intended use without breaking internal dependencies.
internal static unsafe void MemmoveInternal(ref byte dest, ref byte src, nuint len)

@AaronRobinsonMSFT
Copy link
Member Author

/cc @jkotas

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit eb32199 into dotnet:main Apr 30, 2025
141 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the fix_regression branch April 30, 2025 13:59
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Perf][Mono] Speed regression in Buffer.BlockCopy across all Mono AOT and WASM configurations on 3/24/2025 4:04:18 PM +00:00

2 participants