JIT: fix retyping error in object stack allocation #114968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retype GT_STOREIND based on the store address, not the store data, since we need to know if we are retyping fields, and only know that when propagating from the local that forms the store address. Fixes dotnet#111922.
ghost
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a retyping error in the JIT's object stack allocation by basing the retyping decision on the store address rather than the store data. Key changes include:
- Addition of a test case in Retyping.cs to validate the fix.
- Removal of an assertion and restructuring of the condition in objectalloc.cpp to check the field address on the tree node.
- Minor comment update for clarity in the core JIT code.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/JIT/opt/ObjectStackAllocation/Retyping.cs | Added test case for verifying correct retyping of store instructions. |
| src/coreclr/jit/objectalloc.cpp | Modified retyping logic by removing an assertion and checking the field address on tree. |
Files not reviewed (1)
- src/tests/JIT/opt/ObjectStackAllocation/Retyping.csproj: Language not supported
Comments suppressed due to low confidence (1)
src/coreclr/jit/objectalloc.cpp:2045
- Please verify that replacing the original check using parent's AsIndir()->Addr() with tree->OperIs(GT_FIELD_ADDR) adequately covers all cases for retyping GC struct fields.
if (retypeFields && parent->OperIs(GT_STOREIND) && tree->OperIs(GT_FIELD_ADDR) &&
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Need to revise this further. |
This was referenced Apr 23, 2025
This was referenced Apr 23, 2025
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retype GT_STOREIND based on the store address, not the store data, since we need to know if we are retyping fields, and only know that when propagating from the local that forms the store address.
Fixes #111922.