[browser] Use regex to match boot config placeholder #114897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
This reverts commit d278e14.
This was referenced Apr 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where the TypeScript debug build generates an extra space in the boot config placeholder by relaxing the strict string matching to a regex match.
- Introduces a regex to match boot config placeholders allowing for extra space variations.
- Replaces the direct string replace with a regex-based replacement for improved flexibility.
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs
Show resolved
Hide resolved
pavelsavara
approved these changes
Apr 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript debug build generates an extra space in the boot config placeholder.
This PR relaxes the strictness regarding spaces in the boot config placeholder.
Relates to dotnet/aspnetcore#58875