Skip to content

[WinHTTP] Fix ContentDisposition test on FW #114892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

[WinHTTP] Fix ContentDisposition test on FW #114892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,11 @@ await LoopbackServer.CreateClientAndServerAsync(async uri =>
Assert.Contains("close", resp.Headers.Connection);
Assert.True(resp.Headers.ConnectionClose.GetValueOrDefault());
Assert.Equal("attachment", resp.Content.Headers.ContentDisposition.DispositionType);
#if NETFRAMEWORK
Copy link

Copilot AI Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment explaining why the expected FileName value includes quotes on .NET Framework. This will help future maintainers understand the platform-specific behavior.

Copilot uses AI. Check for mistakes.
Assert.Equal("\"fname.ext\"", resp.Content.Headers.ContentDisposition.FileName);
#else
Assert.Equal("fname.ext", resp.Content.Headers.ContentDisposition.FileName);
#endif
Assert.Contains("gzip", resp.Content.Headers.ContentEncoding);
Assert.Contains("da", resp.Content.Headers.ContentLanguage);
Assert.Equal(new Uri("/index.htm", UriKind.Relative), resp.Content.Headers.ContentLocation);
Expand Down
Loading