Skip to content

Delete dead code in the interpreter #114890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Delete dead code in the interpreter #114890

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fabbfa9
Delete dead code in the interpreter
MichalStrehovsky Apr 22, 2025
0b4a0a9
Merge branch 'main' into MichalStrehovsky-patch-2
MichalStrehovsky Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,20 +951,6 @@ private Status TryScanMethod(MethodIL methodIL, Value[] parameters, Stack<Method
return Status.Fail(methodIL.OwningMethod, opcode);
}
}
else if (popped.ValueKind == StackValueKind.ByRef
&& (opcode == ILOpcode.conv_i || opcode == ILOpcode.conv_u)
&& (reader.PeekILOpcode() is (>= ILOpcode.ldind_i1 and <= ILOpcode.ldind_ref) or ILOpcode.ldobj))
{
// In the interpreter memory model, there's no conversion from a byref to an integer.
// Roslyn however sometimes emits a sequence of conv_u followed by ldind and we can
// have a narrow path to handle that one.
//
// For example:
//
// static unsafe U Read<T, U>(T val) where T : unmanaged where U : unmanaged => *(U*)&val;
stack.Push(popped);
goto again;
}
else
{
return Status.Fail(methodIL.OwningMethod, opcode);
Expand Down
Loading