Skip to content

Disable PingTest.CancelSendPingAsync on OSX #114783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Disable PingTest.CancelSendPingAsync on OSX #114783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7be3c4
Disable System.Net.NetworkInformation.Tests.PingTest.CancelSendPingAs…
rzikm Apr 17, 2025
9628904
Update src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
rzikm Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,11 @@ public async Task SendPingAsyncWithAlreadyCanceledToken(bool useIPAddress)
[OuterLoop] // Depends on external host and assumption that successful ping takes long enough for cancellation to go through first
public async Task CancelSendPingAsync(bool useIPAddress, bool useCancellationToken)
{
if (PlatformDetection.IsOSX && useIPAddress && !useCancellationToken)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActiveIssue???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the SkipTestException message

{
throw new SkipTestException("[ActiveIssue(https://github.com/dotnet/runtime/issues/114782)]");
}

using CancellationTokenSource source = new();

using Ping ping = new();
Expand Down Expand Up @@ -870,7 +875,8 @@ public async Task SendPingAsync_LocaleEnvVarsMustBeIgnored(AddressFamily address
{
IPAddress localIpAddress = TestSettings.GetLocalIPAddress(addressFamily);

var remoteInvokeStartInfo = new ProcessStartInfo {
var remoteInvokeStartInfo = new ProcessStartInfo
{
EnvironmentVariables =
{
["LANG"] = envVar_LANG,
Expand Down
Loading