Skip to content

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 17, 2025

Alternative fix for #114766.

@ghost ghost added the area-Host label Apr 17, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 17, 2025
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member

why was the existing code to remove the trailing slash not working?

@am11
Copy link
Member Author

am11 commented Apr 17, 2025

It was not self-assigning __sourceDir (only __ProjectDir). Now it assigns both.

@akoeplinger
Copy link
Member

ah ok got it but I think that might've been a copy/paste mistake, I don't think it should assign __ProjectDir, just strip the trailing slash from __sourceDir

@akoeplinger
Copy link
Member

/ba-g failures are not related to the change

@akoeplinger akoeplinger merged commit e824da7 into dotnet:main Apr 18, 2025
137 of 149 checks passed
@akoeplinger
Copy link
Member

/backport to release/9.0-staging

Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14593733890

@akoeplinger
Copy link
Member

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14593740104

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Host community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants