-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Strip trailing slash from source dir for cmake4 #114779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
why was the existing code to remove the trailing slash not working? |
It was not self-assigning |
ah ok got it but I think that might've been a copy/paste mistake, I don't think it should assign __ProjectDir, just strip the trailing slash from __sourceDir |
/ba-g failures are not related to the change |
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14593733890 |
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14593740104 |
Alternative fix for #114766.