Skip to content

Avoid some redundant casts in DefaultInterpolatedStringHandler.AppendFormatted #114664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Avoid some redundant casts in DefaultInterpolatedStringHandler.AppendFormatted #114664

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa5a62e
Avoid some redundant casts in DefaultInterpolatedStringHandler.Append…
SimonCropp Apr 15, 2025
144b963
Merge remote-tracking branch 'upstream/main' into Avoid-some-redundan…
SimonCropp Apr 15, 2025
2dae793
Merge branch 'main' into Avoid-some-redundant-casts-in-DefaultInterpo…
SimonCropp Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...m.Private.CoreLib/src/System/Runtime/CompilerServices/DefaultInterpolatedStringHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public void AppendFormatted<T>(T value)
// if it only implements IFormattable, we come out even: only if it implements both do we
// end up paying for an extra interface check.
string? s;
if (value is IFormattable)
if (value is IFormattable formattable)
{
// If the value can format itself directly into our buffer, do so.

Expand All @@ -271,10 +271,10 @@ public void AppendFormatted<T>(T value)
return;
}

if (value is ISpanFormattable)
if (value is ISpanFormattable spanFormattable)
{
int charsWritten;
while (!((ISpanFormattable)value).TryFormat(_chars.Slice(_pos), out charsWritten, default, _provider)) // constrained call avoiding boxing for value types
while (!spanFormattable.TryFormat(_chars.Slice(_pos), out charsWritten, default, _provider)) // constrained call avoiding boxing for value types
{
Grow();
}
Expand All @@ -283,7 +283,7 @@ public void AppendFormatted<T>(T value)
return;
}

s = ((IFormattable)value).ToString(format: null, _provider); // constrained call avoiding boxing for value types
s = formattable.ToString(format: null, _provider); // constrained call avoiding boxing for value types
}
else
{
Expand Down Expand Up @@ -317,7 +317,7 @@ public void AppendFormatted<T>(T value, string? format)
// if it only implements IFormattable, we come out even: only if it implements both do we
// end up paying for an extra interface check.
string? s;
if (value is IFormattable)
if (value is IFormattable formattable)
{
// If the value can format itself directly into our buffer, do so.

Expand All @@ -333,10 +333,10 @@ public void AppendFormatted<T>(T value, string? format)
return;
}

if (value is ISpanFormattable)
if (value is ISpanFormattable spanFormattable)
{
int charsWritten;
while (!((ISpanFormattable)value).TryFormat(_chars.Slice(_pos), out charsWritten, format, _provider)) // constrained call avoiding boxing for value types
while (!spanFormattable.TryFormat(_chars.Slice(_pos), out charsWritten, format, _provider)) // constrained call avoiding boxing for value types
{
Grow();
}
Expand All @@ -345,7 +345,7 @@ public void AppendFormatted<T>(T value, string? format)
return;
}

s = ((IFormattable)value).ToString(format, _provider); // constrained call avoiding boxing for value types
s = formattable.ToString(format, _provider); // constrained call avoiding boxing for value types
}
else
{
Expand Down
Loading