Skip to content

Conversation

stephentoub
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings April 14, 2025 18:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 564 out of 564 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.NativeAot.cs:92

  • ArgumentNullException.ThrowIfNull is being applied to an IntPtr (a value type), which will never be null. If the intent is to validate that 'ptr' is not equal to IntPtr.Zero, consider an explicit check for that condition.
ArgumentNullException.ThrowIfNull(ptr);

src/libraries/Common/src/System/ExceptionPolyfills.cs:12

  • [nitpick] Consider adding unit tests to verify the behavior of the new polyfill implementation for ThrowIfNull to ensure it correctly handles various argument types.
extension(ArgumentNullException)

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member Author

/ba-g Failures in ZipArchive (ExtractToDirectoryExtension blocking on monitors on wasm) are known.

@stephentoub stephentoub merged commit 7b2de1e into dotnet:main Apr 18, 2025
143 of 153 checks passed
@stephentoub stephentoub deleted the anepolyfill branch April 18, 2025 21:00
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants