Skip to content

Conversation

@kunalspathak
Copy link
Contributor

Fix build break introduced in #114337

cc: @tomeksowi

Copilot AI review requested due to automatic review settings April 8, 2025 18:33
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@kunalspathak
Copy link
Contributor Author

@dotnet/jit-contrib - superpmi-diffs pipeline is broken because of this.

@risc-vv
Copy link

risc-vv commented Apr 8, 2025

RISC-V Release-CLR-VF2: 9532 / 9552 (99.79%)
=======================
      passed: 9532
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9658
 TOTAL tests: 9658
   REAL time: 2h 8min 56s 267ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: b29fbf7fefd60c2cf218cb18fdb3a38117a5bba4
CI: 09909bfe3d23ad26455327811013bcbb48915255
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9532 / 9552 (99.79%)
=======================
      passed: 9532
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9658
 TOTAL tests: 9658
   REAL time: 2h 47min 2s 176ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: b29fbf7fefd60c2cf218cb18fdb3a38117a5bba4
CI: 09909bfe3d23ad26455327811013bcbb48915255
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 635792 / 663752 (95.79%)
=======================
      passed: 635792
      failed: 1567
     skipped: 1541
      killed: 26393
------------------------
  TOTAL libs: 259
 TOTAL tests: 665293
   REAL time: 2h 34min 48s 503ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: b29fbf7fefd60c2cf218cb18fdb3a38117a5bba4
CI: 09909bfe3d23ad26455327811013bcbb48915255
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

Copy link
Member

@tomeksowi tomeksowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@BruceForstall
Copy link
Contributor

fyi, this shouldn't happen again: the addition of the community JITs build to superpmi-diffs happened after the PR that introduced this failure was tested (including running superpmi-diffs).

@am11 am11 added the arch-riscv Related to the RISC-V architecture label Apr 8, 2025
@am11
Copy link
Member

am11 commented Apr 8, 2025

fyi, this shouldn't happen again: the addition of the community JITs build to superpmi-diffs happened after the PR that introduced this failure was tested (including running superpmi-diffs).

Yes, please merge main to the existing arch-riscv PR branches to find out potential issues with MSVC / windows builds.

@BruceForstall BruceForstall merged commit f7bffcb into dotnet:main Apr 8, 2025
113 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants