[release/9.0-staging][mono][hotreload]Adjust row_size and size_bitfield from the baseline based on the delta sizes #114119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test case to verify that metadata row sizes are adjusted correctly and introduces an autogenerated helper class for the update. Key changes include:
- A new test, TestIncreaseMetadataRowSize, in ApplyUpdateTest.cs validating metadata updates.
- Addition of the autogenerated IncreaseMetadataRowSize class in a new file.
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs | Added a new test case checking metadata row size and method signature. |
| src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize/IncreaseMetadataRowSize.cs | Autogenerated class with placeholder methods for metadata updates. |
Files not reviewed (4)
- src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize.csproj: Language not supported
- src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize/deltascript.json: Language not supported
- src/libraries/System.Runtime.Loader/tests/System.Runtime.Loader.Tests.csproj: Language not supported
- src/mono/mono/component/hot_reload.c: Language not supported
This was referenced Apr 2, 2025
Closed
|
Friendly reminder that code complete is on April 14th for the May Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before that date. |
lewing
approved these changes
Apr 3, 2025
jeffschwMSFT
approved these changes
Apr 7, 2025
This was referenced Apr 7, 2025
leecow
added
Servicing-approved
|
Friendly reminder that code complete for the May release is next Monday April 14th. If you want this change included in that release, please merge the PR before EOD Monday. |
|
/ba-g CI unrelated failures |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #113995 to release/9.0-staging
/cc @thaystg
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2396448
When a customer is trying to apply hotreload on mono runtime depending on how many things are added the hotreload will not work and may hit an assertion or have any weird behavior about not finding methods/assembly with names containing trash value.
Any update in an app that any metadata table is near the size of 65536 will cause it in the first change.
Or any huge change that causes the metadata table size increase.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manually tested and also created a test case.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] Medium risk, because we changed how we read/save the metadata information after a hot reload. But this will only affect mono hotreload customers.