-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/9.0] Move DAC signing identity to PME #114031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the signing identity for diagnostic binaries to use the new PME configuration.
- Updated connected service and authentication IDs to the PME values.
- Revised certificate and tenant information accordingly.
Comments suppressed due to low confidence (2)
eng/pipelines/coreclr/templates/sign-diagnostic-files.yml:18
- Verify that the new connected service name 'diagnostics-esrp-kvcertuser-pme' is correctly set up in your environment to ensure proper connectivity.
ConnectedServiceName: 'diagnostics-esrp-kvcertuser-pme'
eng/pipelines/coreclr/templates/sign-diagnostic-files.yml:23
- Confirm that the updated AuthSignCertName 'dac-dnceng-esrpclient-cert' matches the PME certificate configuration and that the corresponding certificate is available.
AuthSignCertName: 'dac-dnceng-esrpclient-cert'
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14141875850 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. please get a code review. we can treat this as tell mode
Required for SFI requirement of ESRP isolation to production tenants.