Fix Unable to load shared library 'jitinterface_x64' build error on linux/mac #114012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inux/mac When crossgen is first built, it writes the executable and shared lib artifacts to `artifacts/bin/coreclr/<os>.<arch>.<config>/<arch>/crossgen2`. On subsequent builds, the native libs are cleaned and never copied back even though they are included as <Content> items in crossgen.props. This can cause the build to fail later on down the line when we attempt to use the in build crossgen on different assemblies as it won't find the native libs it depends on. To work around the issue, this change adds a target that runs after publish and copies the content items to $(PublishDir). It's not clear if this is a bug in the SDK or something we're not doing correctly. More investigation is suggested. Fixes dotnet#111731
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (4)
- src/coreclr/tools/aot/crossgen2/crossgen2.props: Language not supported
- src/coreclr/tools/aot/crossgen2/crossgen2.targets: Language not supported
- src/coreclr/tools/aot/crossgen2/crossgen2_inbuild.csproj: Language not supported
- src/coreclr/tools/aot/crossgen2/crossgen2_publish.csproj: Language not supported
ghost
added
the
jkoritzinsky
approved these changes
Mar 28, 2025
…ror on linux/mac" This reverts commit 08214fd.
|
Thanks @akoeplinger ! |
This was referenced Mar 28, 2025
jkoritzinsky
approved these changes
Mar 28, 2025
|
/ba-g Networking failures |
This was referenced Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When crossgen is first built, it writes the executable and shared lib artifacts to
artifacts/bin/coreclr/<os>.<arch>.<config>/<arch>/crossgen2. On subsequent builds the native libs are cleaned and never copied back (by the SDK) even though they are included as items in crossgen.props. This can cause the build to fail later on down the line when we attempt to use the in build crossgen on different assemblies as it won't find the native libs it depends on.We need to set
ExcludeFromSingleFile=trueso that the publishing logic knows that we want to not include these files in the singlefile bundle.See https://github.com/dotnet/designs/blob/main/accepted/2020/single-file/design_3_0.md
Fixes #111731