Add CPUID for AvxVnniInt8 and AvxVnniInt16 #113956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
khushal1996
force-pushed
the
kcm-avxvnniint8-cpuid
branch
from
6714249 to
141d643
Compare
This was referenced Mar 27, 2025
|
@tannergooding This is first of the 2 PRs needed for AVX VNNI INT* API introduction #112586 |
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt
Outdated
Show resolved
Hide resolved
khushal1996
force-pushed
the
kcm-avxvnniint8-cpuid
branch
from
141d643 to
98fc970
Compare
|
@tannergooding @saucecontrol I have added the CPUID, API surface, JIT handling and template tests here. |
This was referenced Apr 15, 2025
Open
khushal1996
force-pushed
the
kcm-avxvnniint8-cpuid
branch
from
e6cf454 to
90fa072
Compare
3 tasks
tannergooding
approved these changes
Jun 18, 2025
Co-authored-by: Tanner Gooding <[email protected]>
This was referenced Jun 23, 2025
EgorBo
approved these changes
Jul 1, 2025
|
@khushal1996 could you please resolve the merge conflict? |
|
Resolved the merge conflicts. I'll get this merged once CI completes |
|
Thanks @tannergooding for picking this up. Let me know if you want me to take over if the CI fails. |
This was referenced Jul 7, 2025
|
Thanks for helping with the review and fixes @tannergooding |
|
Thanks as well for getting the feature implemented and done @khushal1996. Fixes were just some minor merge conflict fixes from other cleanup/simplifications that had happened |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for CPUID for
AVX-VNNI-INT8&AVX-VNNI-INT16ISAsThis resolves #112586
Design
The changes are made in a way to enable the 2 ISAs when
Avx10.2is enabled orThis is w.r.t the discussions done in API proposal #112586
Testing
Note1: Emitter unit tests not ran since they are added and verified along with AVX10.2 PR #111209
Note2: Superpmi results are not accurate since we are adding a new CPUID and it leads to a new jiteeversionguid. Even after changing the jiteeversion manually, superpmi run shows errors and failures based on the old mch files which can be ignored.
Run JIT subtree with AVXVNNIINT* enabled / disabled
AVXVNNIINT* Enabled
AVXVNNIINT* disabled
