Skip to content

Unify the JsonDocument and Utf8JsonReader handling of DateTime/Offset #113929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

Unify the JsonDocument and Utf8JsonReader handling of DateTime/Offset #113929

merged 2 commits into from
Jun 3, 2025

Conversation

@IDisposable
Copy link
Contributor

@IDisposable IDisposable commented Mar 26, 2025

Since so much of the code is identical, move it to JsonReaderHelper and call into it from JsonDocument.cs and Utf8JsonReader.TryGet.cs
Closes #28931

@IDisposable
Unify the JsonDocument and Utf8JsonReader handling of DateTime/Offset
9a2f86a 
Since so much of the code is identical, move it to JsonReaderHelper
Closes dotnet#28931
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 26, 2025
@IDisposable IDisposable mentioned this pull request Mar 26, 2025
Closed
This was referenced Mar 26, 2025
Closed
Closed
@PranavSenthilnathan PranavSenthilnathan self-requested a review May 26, 2025 08:54
@build-analysis build-analysis bot mentioned this pull request May 28, 2025
Closed
@stephentoub stephentoub merged commit a2c9e7b into dotnet:main Jun 3, 2025
86 checks passed
@stephentoub
Copy link
Member

stephentoub commented Jun 3, 2025

Thanks

@IDisposable IDisposable deleted the unify-json-date-parsing branch June 3, 2025 02:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PranavSenthilnathan PranavSenthilnathan PranavSenthilnathan approved these changes

Assignees

No one assigned

Labels

area-System.Text.Json community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extract Utf8Parser date helpers to static helper class

3 participants

@IDisposable @stephentoub @PranavSenthilnathan