Skip to content

Fix targets for using the NativeAOT runtime pack as the "target ILC" pack #113902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

Fix targets for using the NativeAOT runtime pack as the "target ILC" pack #113902

merged 2 commits into from
Mar 27, 2025

Conversation

@jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Mar 25, 2025 •
edited
Loading

Change how we select the assets as we aren't using this package as a runtime pack.

Unblocks dotnet/sdk#46611

@jkoritzinsky
Don't look at RuntimePackAsset items when using the runtime pack layo…
369812e 
…ut but not actually using it as a runtime pack. The NAOT assemblies won't be there.
Copilot AI review requested due to automatic review settings March 25, 2025 22:16
Copilot AI reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets: Language not supported

@jkoritzinsky jkoritzinsky requested a review from sbomer March 25, 2025 22:16
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

am11
am11 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@am11 am11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This was referenced Mar 26, 2025
Open
Closed
Closed
Closed
Closed
sbomer
sbomer approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you fixglobbing for _NETCoreAppRuntimePackPath as discussed. Thanks!

@jkoritzinsky
Copy link
Member Author

/ba-g failures unrelated

@jkoritzinsky jkoritzinsky merged commit 9b091dc into dotnet:main Mar 27, 2025
94 of 96 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@sbomer sbomer sbomer approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

+1 more reviewer

@am11 am11 am11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinsky jkoritzinsky

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkoritzinsky @sbomer @am11