Try improving reliability of TestLongProcessIsWorking #113519
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request dotnet#111850 improved reliability of this test for a bit but after we upgraded Helix machines to the new macOS, this test started very reliably fail with native AOT. My theory is that copying the binary around makes macOS treat the binary as a new thing that needs to be checked for signing/malware/etc and this takes a long time. So stop copying the binary.
ghost
added
the
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the reliability of TestLongProcessIsWorking by eliminating the binary copying step, which appears to cause delays on macOS due to code signing and malware checks.
- Removed conditional branch that distinguishes Linux from other platforms
- Always creates a wrapped sleep script using GetTestFilePath() instead of copying the sleep binary
Comments suppressed due to low confidence (1)
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs:2274
- Removing the OS check may cause unintended behavior on platforms other than macOS. Consider adding a conditional check (e.g., OperatingSystem.IsMacOS()) to ensure this new behavior is only applied where needed.
string sleepPath = GetTestFilePath();
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 14, 2025
Member
Author
Nope, going to block it instead at #113600. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #111850 improved reliability of this test for a bit but after we upgraded Helix machines to the new macOS, this test started very reliably fail with native AOT. My theory is that copying the binary around makes macOS treat the binary as a new thing that needs to be checked for signing/malware/etc and this now takes much longer than it used to. So stop copying the binary.