Skip to content

[Apple mobile] Run System.Runtime.Serialization.Xml.ExporterTypesTests.TypesTest when DataSetXmlSerializationIsSupported is set #113084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2025
Merged

[Apple mobile] Run System.Runtime.Serialization.Xml.ExporterTypesTests.TypesTest when DataSetXmlSerializationIsSupported is set #113084

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0ba3dc
Set DataSetXmlSerializationSupport to true
kotlarmilos Mar 3, 2025
807ee37
Fix name
kotlarmilos Mar 3, 2025
cc7c6cc
Conditionally run the test
kotlarmilos Mar 13, 2025
a823dcf
Remove props in the csproj
kotlarmilos Mar 13, 2025
9e494f8
Disable test
kotlarmilos Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...System.Runtime.Serialization.Xml/tests/XsdDataContractExporterTests/ExporterTypesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public ExporterTypesTests(ITestOutputHelper output)
_output = output;
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.DataSetXmlSerializationIsSupported))]
public void TypesTest()
{
var types = new List<Type>()
Expand Down Expand Up @@ -79,7 +79,7 @@ public static IEnumerable<object[]> GetDynamicallyVersionedTypesTestNegativeData
};
}

[Theory]
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.DataSetXmlSerializationIsSupported))]
[SkipOnPlatform(TestPlatforms.Browser, "Inconsistent and unpredictable results.")] // TODO - Why does 'TypeWithReadWriteCollectionAndNoCtorOnCollection' only cause an exception sometimes, but not all the time? What's special about wasm here?
[ActiveIssue("https://github.com/dotnet/runtime/issues/82967", TestPlatforms.Wasi)]
[InlineData(typeof(NoDataContractWithoutParameterlessConstructor), typeof(InvalidDataContractException), @"Type 'System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests+NoDataContractWithoutParameterlessConstructor' cannot be serialized. Consider marking it with the DataContractAttribute attribute, and marking all of its members you want serialized with the DataMemberAttribute attribute. Alternatively, you can ensure that the type is public and has a parameterless constructor - all public members of the type will then be serialized, and no attributes will be required.")]
Expand Down
Loading