Fix TensorPrimitives.MultiplyAddEstimate for integers #113047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
There was a problem hiding this comment.
PR Overview
This PR fixes the MultiplyAddEstimate implementation for integer types by updating both the test cases and the low‐level implementation details.
- Updated tests to use T.MultiplyAddEstimate instead of T.FusedMultiplyAdd.
- Added a new suite of tests for Span, Span, Span destination scenarios.
- Adjusted type checks in the MultiplyAddEstimate implementation to better differentiate float handling.
Reviewed Changes
| File | Description |
|---|---|
| src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs | Updates tests to correctly use MultiplyAddEstimate and adds additional span destination tests |
| src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.MultiplyAddEstimate.cs | Refines type-check conditions for vectorized operations |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
Outdated
Show resolved
Hide resolved
...Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.MultiplyAddEstimate.cs
Outdated
Show resolved
Hide resolved
tannergooding
approved these changes
Mar 3, 2025
stephentoub
commented
Mar 3, 2025
...Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.MultiplyAddEstimate.cs
Outdated
Show resolved
Hide resolved
...Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.MultiplyAddEstimate.cs
Outdated
Show resolved
Hide resolved
...Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.MultiplyAddEstimate.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13640313235 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112989
Introduced in #102181