[browser][http] mute JS exceptions about network errors + HEAD verb #113014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to this area: @dotnet/ncl |
campersau
reviewed
Feb 28, 2025
Co-authored-by: campersau <[email protected]>
…ara/runtime into browser_http_mute_abort
pavelsavara
changed the title
This was referenced Feb 28, 2025
3 tasks
This was referenced Mar 3, 2025
campersau
reviewed
Mar 6, 2025
akoeplinger
approved these changes
Mar 7, 2025
src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/EchoHandler.cs
Outdated
Show resolved
Hide resolved
…ver/Handlers/EchoHandler.cs Co-authored-by: Alexander Köplinger <[email protected]>
javiercn
approved these changes
Mar 7, 2025
campersau
approved these changes
Mar 7, 2025
src/libraries/Common/tests/System/Net/Http/ResponseStreamTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Http/ResponseStreamTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/EchoHandler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: campersau <[email protected]>
…ver/Handlers/EchoHandler.cs Co-authored-by: campersau <[email protected]>
Co-authored-by: campersau <[email protected]>
|
/ba-g known CI issue #110805 |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/13725376350 |
4 tasks
pavelsavara
added a commit
to pavelsavara/runtime
that referenced
this pull request
Mar 7, 2025
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In browser HTTP client we subscribe for rejected promises in order to suppress unhandled rejection of
AbortErrorwhen we issue the abort. The current handler also handles other network errors and aborts the whole program, which is not what it should do. Instead the network error should be propagated to managed HTTP client code.in Firefox when the verb is HEAD, the body is null. We should not fail because of that.
Passing
Responseas result ofhttp_wasm_fetchis creating JS memory leak by marshaling the object.Contributes to #112172
Contributes to #111992
This bug fix should be back ported.