Skip to content

Conversation

max-charlamb
Copy link
Member

#111759 broke Windows non-x64 builds by trying to link native unwinders which didn't exist.

Adds conditional to only link unwinders on Windows x64

@Copilot Copilot AI review requested due to automatic review settings February 27, 2025 20:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 27, 2025
@max-charlamb max-charlamb added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 27, 2025
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@steveisok
Copy link
Member

/ba-g Merging to unblock official build.

@steveisok steveisok merged commit b0e9b73 into dotnet:main Feb 27, 2025
43 of 123 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2025
@max-charlamb max-charlamb deleted the cdac-native-unwinder-fix branch June 10, 2025 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants