Fix the unsigned right shift operator of BigInteger #112879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Feb 25, 2025
Open
tannergooding
approved these changes
Feb 27, 2025
tannergooding
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Add tests for the shift operator of BigInteger * Fix the unsigned right shift operator of BigInteger * avoid stackalloc * external sign element
tannergooding
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Add tests for the shift operator of BigInteger * Fix the unsigned right shift operator of BigInteger * avoid stackalloc * external sign element
tannergooding
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Add tests for the shift operator of BigInteger * Fix the unsigned right shift operator of BigInteger * avoid stackalloc * external sign element
This was referenced Feb 27, 2025
tannergooding
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Add tests for the shift operator of BigInteger * Fix the unsigned right shift operator of BigInteger * avoid stackalloc * external sign element
jeffhandley
pushed a commit
that referenced
this pull request
Mar 10, 2025
* Add BigInteger.Rotate* tests * Fix BigInteger.Rotate* * avoid stackalloc * Add comment * Fix the unsigned right shift operator of BigInteger (#112879) * Add tests for the shift operator of BigInteger * Fix the unsigned right shift operator of BigInteger * avoid stackalloc * external sign element --------- Co-authored-by: kzrnm <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #112564
Related #112878
Using
BigInteger.GetPartsForBitManipulationwill result in incorrect two's complement calculations for negative numbers where the most significant bit is set. For correct unsigned right shift, this method should not be used.