Skip to content

Conversation

lewing
Copy link
Member

@lewing lewing commented Feb 21, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings February 21, 2025 23:05
@lewing lewing requested a review from pavelsavara as a code owner February 21, 2025 23:05
@ghost ghost added the area-Build-mono label Feb 21, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

<Project Sdk="{sdk}">
<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net{Environment.Version}.0</TargetFramework>

similar to https://github.com/dotnet/runtime/pull/79219/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but not worth restarting CI, we can update it in a separate PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoeplinger akoeplinger merged commit d8a7c7b into dotnet:main Feb 26, 2025
151 of 155 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants