[8.0] Wrap the OneLocBuild yml section with a SourceBranch check #112458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
Servicing-approved
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
jkoritzinsky
approved these changes
Feb 12, 2025
This was referenced Feb 12, 2025
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell-mode, infra only.
From a conversation with @cristianosuzuki77 , the OneLocBuild yaml section in 9.0 and main is protected with a SourceBranch check. We can add the same to release/8.0 to prevent the build from running and also to reduce confusion when the Loc team has to troubleshoot issues in runtime.
https://github.com/dotnet/runtime/blob/release/9.0/eng/pipelines/runtime-official.yml#L40-L50
https://github.com/dotnet/runtime/blob/main/eng/pipelines/runtime-official.yml#L40-L50
Sending this directly to release/8.0 as we still have runway to merge to that branch. Ideally we want this to flow to internal right away, and it will automatically flow to staging with the autogenerated PRs.