-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix ref files from System.IO.Compression and System.IO.Compression.Brotli with autogenerated file using GenAPI #112440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
6a88dc1
643f62c
4b9e3bc
b733cf1
fa9a7fd
2bd8e37
195d714
e54eab4
0a2d168
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -51,7 +51,7 @@ public override void SetLength(long value) { } | |||||||||||
| public override void Write(byte[] buffer, int offset, int count) { } | ||||||||||||
| public override void Write(System.ReadOnlySpan<byte> buffer) { } | ||||||||||||
| public override System.Threading.Tasks.Task WriteAsync(byte[] buffer, int offset, int count, System.Threading.CancellationToken cancellationToken) { throw null; } | ||||||||||||
| public override System.Threading.Tasks.ValueTask WriteAsync(System.ReadOnlyMemory<byte> buffer, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; } | ||||||||||||
| public override System.Threading.Tasks.ValueTask WriteAsync(System.ReadOnlyMemory<byte> buffer, System.Threading.CancellationToken cancellationToken) { throw null; } | ||||||||||||
|
||||||||||||
| public override void WriteByte(byte value) { } | ||||||||||||
| } | ||||||||||||
| public partial class GZipStream : System.IO.Stream | ||||||||||||
|
|
@@ -131,18 +131,30 @@ public enum ZipArchiveMode | |||||||||||
| Create = 1, | ||||||||||||
| Update = 2, | ||||||||||||
| } | ||||||||||||
| public sealed class ZLibCompressionOptions | ||||||||||||
| public sealed partial class ZLibCompressionOptions | ||||||||||||
| { | ||||||||||||
| public int CompressionLevel { get; set; } | ||||||||||||
| public ZLibCompressionStrategy CompressionStrategy { get; set; } | ||||||||||||
| public ZLibCompressionOptions() { } | ||||||||||||
ericstj marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||
| public int CompressionLevel { get { throw null; } set { } } | ||||||||||||
| public System.IO.Compression.ZLibCompressionStrategy CompressionStrategy { get { throw null; } set { } } | ||||||||||||
| } | ||||||||||||
| public enum ZLibCompressionStrategy | ||||||||||||
| { | ||||||||||||
| Default = 0, | ||||||||||||
| Filtered = 1, | ||||||||||||
| HuffmanOnly = 2, | ||||||||||||
| RunLengthEncoding = 3, | ||||||||||||
| Fixed = 4 | ||||||||||||
| Fixed = 4, | ||||||||||||
| } | ||||||||||||
| public partial class ZLibException : System.IO.IOException, System.Runtime.Serialization.ISerializable | ||||||||||||
|
||||||||||||
| <!-- Exposed publicly only in implementation for serialization compat. --> | |
| <Suppression> | |
| <DiagnosticId>CP0001</DiagnosticId> | |
| <Target>T:System.IO.Compression.ZLibException</Target> | |
| </Suppression> |
Perhaps you can configure GenAPI so that it will exclude it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me understand how it works first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open an issue to keep investigating later #112451
I'll jump to work on the m-p issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment to #112451 (comment) with how to do this. Your call if you want to do it in this PR or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks. I think I should do it in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed the changes. Nice to see that after creating the txt file and adding that property to the csproj, the ZLibException is no longer getting auto-added to the ref cs when running the dotnet msbuild /t:GenerateReferenceAssemblySource command.
Uh oh!
There was an error while loading. Please reload this page.